Re: Retiring support for pre-7.3 FK constraint triggers

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2020-Mar-05, Daniel Gustafsson wrote:
>> While looking at the tg_updatedcols patch I happened to notice that we still
>> support pre-7.3 constraint triggers by converting them on the fly.  AFAICT this
>> requires a pre-7.3 dump to hit.

> I know it's a late in the cycle for patches in commitfest, but why not
> consider this for pg13 nonetheless?  It seems simple enough.  Also, per
> https://coverage.postgresql.org/src/backend/commands/trigger.c.gcov.html
> this is the only large chunk of uncovered code in commands/trigger.c.

+1 --- I think this fits in well with my nearby proposal to remove
OPAQUE, which is also only relevant for pre-7.3 dumps.  Let's just
nuke that stuff.

            regards, tom lane