Re: WIP: splitting BLCKSZ
От | Simon Riggs |
---|---|
Тема | Re: WIP: splitting BLCKSZ |
Дата | |
Msg-id | 1144226918.13549.585.camel@localhost.localdomain обсуждение исходный текст |
Ответ на | Re: WIP: splitting BLCKSZ (Tom Lane <tgl@sss.pgh.pa.us>) |
Список | pgsql-patches |
On Tue, 2006-04-04 at 18:41 -0400, Tom Lane wrote: > Simon Riggs <simon@2ndquadrant.com> writes: > > On Tue, 2006-04-04 at 11:13 -0400, Tom Lane wrote: > >> Hm. The entire point of having a BLCKSZ-sized control file is to have > >> it *not* change in size across format revisions (see the comments) ... > >> which I suppose means that we really ought to have a hard-wired separate > >> constant, rather than depending on something that someone might want to > >> twiddle. > > > Patch enclosed. > > Applied with minor editorialization Thanks. > (I thought the symbol ought to be > defined in pg_control.h, not some random xlog file). It wasn't a random xlog header file. The symbol was placed adjacent to this line in xlog_internal.h #define XLOG_CONTROL_FILE "global/pg_control" Perhaps that should be moved to pg_control.h also? Or at least a comment in pg_control to indicate where pg_control's location is defined. Best Regards, Simon Riggs
В списке pgsql-patches по дате отправления: