I just realized that we have a bit of a problem with upgrading row
locks. Consider the following sequence:
regression=# begin;
BEGIN
regression=# select * from int4_tbl where f1 = 0 for share;f1
---- 0
(1 row)
regression=# savepoint x;
SAVEPOINT
regression=# select * from int4_tbl where f1 = 0 for update;f1
---- 0
(1 row)
regression=# rollback to x;
ROLLBACK
The FOR UPDATE replaces the former shared row lock with an exclusive
lock in the name of the subtransaction. After the ROLLBACK, the row
appears not to be locked at all (it is ex-locked with XMAX = a failed
transaction), so another backend could come along and modify it.
That shouldn't happen --- we should act as though the outer
transaction's FOR SHARE lock is still held.
Unfortunately, I don't think there is any good way to implement that,
since we surely don't have room in the tuple header to track multiple
locks. One possibility is to try to assign the ex-lock in the name
of the highest subtransaction holding a row lock, but that seems messy,
and it wouldn't really have the correct semantics anyway --- in the
above example, the outer transaction would be left holding ex-lock
which would be surprising.
I'm tempted to just error out in this scenario rather than allow the
lock upgrade. Thoughts?
regards, tom lane