Re: Bug in CVS pg_dump against 7.0.x

Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:
>> Do we know that is always true?  What is the issue that 7.0 needs this
>> and newer released don't, and how are we sure this will not break some
>> strange cases in post-7.0 releases?

> It's not a problem, since that code path is only ever executed when
> dumping a 7.0 backend.  It's in the MyFormatType function in pg_dump.c
> that is used whenever the backend doesn't have its own format_type function.

Right.  The patch looked dangerous to me too, until I understood the
context.  As-is, I think it's fine -- indeed, I think we ought to
backpatch it into 7.4 branch too.

            regards, tom lane