Memory leaks in BufFileOpenShared()
От | Antonin Houska |
---|---|
Тема | Memory leaks in BufFileOpenShared() |
Дата | |
Msg-id | 11329.1529045692@localhost обсуждение исходный текст |
Ответы |
Re: Memory leaks in BufFileOpenShared()
|
Список | pgsql-hackers |
Memory is allocated twice for "file" and "files" variables. Possible fix: diff --git a/src/backend/storage/file/buffile.c b/src/backend/storage/file/buffile.c index d8a18dd3dc..00f61748b3 100644 --- a/src/backend/storage/file/buffile.c +++ b/src/backend/storage/file/buffile.c @@ -277,10 +277,10 @@ BufFileCreateShared(SharedFileSet *fileset, const char *name) BufFile * BufFileOpenShared(SharedFileSet *fileset, const char *name) { - BufFile *file = (BufFile *) palloc(sizeof(BufFile)); + BufFile *file; char segment_name[MAXPGPATH]; Size capacity = 16; - File *files = palloc(sizeof(File) * capacity); + File *files; int nfiles = 0; file = (BufFile *) palloc(sizeof(BufFile)); -- Antonin Houska Cybertec Schönig & Schönig GmbH Gröhrmühlgasse 26, A-2700 Wiener Neustadt Web: https://www.cybertec-postgresql.com
В списке pgsql-hackers по дате отправления: