Re: pgsql: move hex_decode() to /common so it can be called from frontend

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: move hex_decode() to /common so it can be called from frontend
Дата
Msg-id 1124719.1608862827@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: pgsql: move hex_decode() to /common so it can be called from frontend  (Bruce Momjian <bruce@momjian.us>)
Список pgsql-committers
Bruce Momjian <bruce@momjian.us> writes:
> I now understand the wisdom of your suggestion.  Attached is a patch
> that removes hex_decode from ecpg properly, and returns -1 from the
> /common version.

I'm fairly unimpressed with this.  I don't like having fundamentally
different (and 100% undocumented) behaviors between the frontend and
backend versions of the "same" function.

I think you should leave ecpglib alone.  Unifying that little bit
of code isn't worth having to contort the API of the common version.

            regards, tom lane



В списке pgsql-committers по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: pgsql: move hex_decode() to /common so it can be called from frontend
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Avoid time-of-day-dependent failure in log rotation test.