Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path

Поиск
Список
Период
Сортировка
От MauMau
Тема Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path
Дата
Msg-id 10DE394009FB4117B17C8807B92FDB62@maumau
обсуждение исходный текст
Ответ на Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path  (Rajeev rastogi <rajeev.rastogi@huawei.com>)
Ответы Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path  (Rajeev rastogi <rajeev.rastogi@huawei.com>)
Список pgsql-hackers
Hi Rajeev,

From: "Rajeev rastogi" <rajeev.rastogi@huawei.com>
Changed the patch as per your suggestion.
Now only one version of make_absolute_path there defined in src/port/path.c

Found one small memory leak in the existing function 
make_absolute_path(miscinit.c),
fixed the same.


Thanks for refactoring.  I confirmed that the revised patch applies to HEAD 
cleanly, the source files built without extra warnings, and the original 
intended problem was solved.

Please make small cosmetic changes so that make_absolute_path() follows the 
style of other parts.  Then I'll make this ready for committer.

(1)
Add the function name in the comment as in:

/** make_absolute_path** ...existing function descripton*/


(2)
Add errno description as in:

fprintf(stderr, _("could not get current working directory: %s\n", 
strerror(errno)));


Regards
MauMau




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Thom Brown
Дата:
Сообщение: pg_stat_tmp files for dropped databases
Следующее
От: Tomas Vondra
Дата:
Сообщение: Re: pg_stat_tmp files for dropped databases