hash_create(): check return code
От
Neil Conway
Тема
hash_create(): check return code
Дата
Msg-id
1098423655.6602.287.camel@localhost.localdomain
Список
Дерево обсуждения
hash_create(): check return code Neil Conway <neilc@samurai.com>
Re: hash_create(): check return code Tom Lane <tgl@sss.pgh.pa.us>
Re: hash_create(): check return code Neil Conway <neilc@samurai.com>
Re: hash_create(): check return code Tom Lane <tgl@sss.pgh.pa.us>
Re: hash_create(): check return code Neil Conway <neilc@samurai.com>
Re: hash_create(): check return code Tom Lane <tgl@sss.pgh.pa.us>
Re: hash_create(): check return code Neil Conway <neilc@samurai.com>
hash_create() can return a NULL pointer if an error occurs (principally, when we're out of memory). Some of the call sites checked for this condition, but some did not. This patch fixes the remaining call sites to check the return value, and ereport(ERROR) if it is NULL. I'm not really sure whether this is the correct fix, but it certainly seems wrong to be doing the check in some places and not in others. Another approach would be to elog(ERROR) when an error occurs in hash_create(), which would be fine except there might be some circumstances in which hash_create() is invoked but elog(ERROR) is not setup yet. Comments? -Neil (Patch attached as a unified diff -- apologies for that, but I'm playing with a new version control tool that most easily emits unified diffs. http://www.venge.net/monotone/, if you're curious.)
В списке pgsql-patches по дате отправления