Re: TAP test breakage on MacOS X

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: TAP test breakage on MacOS X
Дата
Msg-id 10573.1414354799@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: TAP test breakage on MacOS X  (Andrew Dunstan <andrew@dunslane.net>)
Список pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 10/26/2014 12:29 PM, Tom Lane wrote:
>> The pathname length problem I noted in
>> http://www.postgresql.org/message-id/16477.1413831571@sss.pgh.pa.us
>> seems like a show-stopper as well, since undoubtedly a number of
>> buildfarm critters are using buildroots with paths long enough to
>> trigger it.

> +1 for fixing that, although it seems like a problem in what's being 
> tested rather than in the test suite.

I agree, but nonetheless we don't want the buildfarm turning mostly
red because we enable TAP before fixing this.

>> The larger issue though is that even with both the above things fixed,
>> the TAP tests would still be an expensive no-op on the majority of
>> buildfarm members.

> As far as the buildfarm goes, we could make it a cheap noop by checking 
> for the presence of the required modules (AFAIK that's Test::More, 
> IPC::CMD and IPC::Run).

You'd probably have to check not just presence but version; but yeah,
that is a potential solution to the cycle-wastage problem.

> I agree that just having it not run tests on most platforms is hardly a 
> solution.

It doesn't do much to make the tests actually useful, for sure ...
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: Re: strip nulls functions for json and jsonb
Следующее
От: Andrew Dunstan
Дата:
Сообщение: Re: strip nulls functions for json and jsonb