Amit Kapila <amit.kapila16@gmail.com> writes:
> On Sun, May 26, 2019 at 2:20 AM Alexander Lakhin <exclusion@gmail.com> wrote:
>> 5. ExecContextForcesOids - not changed, but may be should be removed
>> (orphaned after 578b2297)
> Yes, we should remove the use of ExecContextForcesOids.
Unless grep is failing me, ExecContextForcesOids is in fact gone.
All that's left is one obsolete mention in a comment, which should
certainly be cleaned up.
However, the full context of the mention is
/*
* call ExecInitNode on each of the plans to be executed and save the
* results into the array "mt_plans". This is also a convenient place to
* verify that the proposed target relations are valid and open their
* indexes for insertion of new index entries. Note we *must* set
* estate->es_result_relation_info correctly while we initialize each
* sub-plan; ExecContextForcesOids depends on that!
*/
which makes one wonder if the code to twiddle
estate->es_result_relation_info during subplan init is dead code. If so
we probably ought to remove it, as it's surely confusing. If it's not
dead, then this comment ought to be updated to explain the surviving
reason(s), not simply deleted.
regards, tom lane