Revised xml memory allocation patch

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Revised xml memory allocation patch
Дата
Msg-id 10561.1200362129@sss.pgh.pa.us
обсуждение исходный текст
Ответы Re: Revised xml memory allocation patch  (Neil Conway <neilc@samurai.com>)
Список pgsql-patches
Attached is my revision of Alvaro's patch to change xml.c so that libxml
memory allocations happen in a specially designated context.  I find
this more convincing than the existing technique of using whatever
context xml.c happens to be called in.  It should also be marginally
faster because (barring errors) we only need to reset libxml once per
transaction not once per xml.c function call.  On the other hand it's
kind of late in the beta cycle to be changing anything so low-level,
and as of today I cannot point to any specific bug it would fix.

Any thoughts whether to apply or not?

Note: the patch removes most of the PG_TRY blocks in xml.c.  For ease of
reading I did not reindent the contained code, but will do so before
applying, if we choose to apply.

            regards, tom lane


Вложения

В списке pgsql-patches по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Revised patch for fixing archiver shutdown behavior
Следующее
От: Neil Conway
Дата:
Сообщение: Re: Revised xml memory allocation patch