Re: BUG #16622: pg_dump produces erroneus ALTER TABLE statement for a table with an inherited generated column

Daniel Gustafsson <daniel@yesql.se> writes:
>> On 18 Sep 2020, at 06:58, PG Bug reporting form <noreply@postgresql.org> wrote:
>> psql:dump.sql:50: ERROR:  column "b" of relation "gtest1_1" is a generated
>> column

> I can reproduce this in git HEAD too.

Yeah, this has been complained of before, notably at [1].
The latest patch in that thread is Masahiko-san's at [2],
which is similar to but not exactly like yours.
Could you review/test that one?

(I suspect you are right that binary-upgrade is a special case,
but wouldn't the existing pg_upgrade test catch that?  Also,
do we need more test cases?)

            regards, tom lane

[1] https://www.postgresql.org/message-id/flat/15830.1575468847%40sss.pgh.pa.us
[2] https://www.postgresql.org/message-id/CA%2Bfd4k6pLzrZDQsdsxcS06AwGRf1DgwOw84sFq9oXNw%2B83nB1g%40mail.gmail.com