Re: [PATCH] Negative Transition Aggregate Functions (WIP)

"Erik Rijkers" <er@xs4all.nl> writes:
> The TRACE_POSTGRESQL_SORT_DONE warnings were not from your patch; sorry about that. They occur on HEAD too (with a
debug
> compile).

> tuplesort.c:935:44: warning: comparison between pointer and integer [enabled by default]
>   TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, spaceUsed);
>                                             ^
> tuplesort.c:935:2: note: in expansion of macro �
>   TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, spaceUsed);


FWIW, I don't see any such warnings on either of the machines I have that
will accept --enable-dtrace.  state->tapeset is a pointer, so these
warnings look a tad bogus.
        regards, tom lane