Re: Coding in WalSndWaitForWal

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> In modern times, we define pg_attribute_noreturn() like this:

> /* GCC, Sunpro and XLC support aligned, packed and noreturn */
> #if defined(__GNUC__) || defined(__SUNPRO_C) || defined(__IBMC__)
> #define pg_attribute_noreturn() __attribute__((noreturn))
> #define HAVE_PG_ATTRIBUTE_NORETURN 1
> #else
> #define pg_attribute_noreturn()
> #endif

> I suppose this will cause warnings in compilers other than those, but
> I'm not sure if we care.  What about MSVC for example?

Yeah, the lack of coverage for MSVC seems like the main reason not
to assume this works "everywhere of interest".

> With the attached patch, everything compiles cleanly in my setup, no
> warnings, but then it's GCC.

Meh ... I'm not really convinced that any of those changes are
improvements.  Particularly not the removals of switch-case breaks.

            regards, tom lane