Re: make check failures in current cvs

Michael,

This is fantastic! Good work.

FYI The way the development works on this project is that whatever makes
it into cvs before the code freeze makes it into the next version. So if
your patch is accepted before the code freeze then it will be in 7.3

Acceptance into cvs is up to Barry and I's discretion. The criteria here
aren't very strict. It needs to work, and be reasonably written code. We
will feed back to you what we don't like.

Dave
On Wed, 2002-06-26 at 14:51, Michael Adler wrote:
>
> Thanks guys for the info on the tests. It's good to know I didn't break
> something.
>
> I've got COPY (and its unit tests) working consistently, but it needs to
> be more efficent/scalable. I'm testing it out with 8-35 meg copies. I'll
> post ASAP. If this were incorporated, would it go into 7.3?
>
> On Wed, 26 Jun 2002, Barry Lind wrote:
>
> > Dave,
> >
> > I believe the last one also needs to be fixed in the test case.  I think
> > it is related to a bugfix I did last weekend.
> >
> > Michael,
> >
> > I think all three failures are problems with the tests not problems with
> > the code.
> >
> > thanks,
> > --Barry
> >
> >
> > Dave Cramer wrote:
> >
> > >Barry,
> > >
> > >My comments are below
> > >
> > >
> > >On Wed, 2002-06-26 at 12:44, Barry Lind wrote:
> > >
> > >
> > >>Dave,
> > >>
> > >>Have you seen these errors in the test suite before?
> > >>
> > >>thanks,
> > >>--Barry
> > >>
> > >>
> > >>Michael Adler wrote:
> > >>
> > >>
> > >>
> > >>>While adding some test methods to test the COPY protocol, I've notice some
> > >>>failures in the current cvs. Is this to be expected? Or does this point to
> > >>>a problem with my local setup?
> > >>>
> > >>>test:
> > >>>   [junit] .................F......F................F..
> > >>>   [junit] ...............
> > >>>   [junit] Time: 12.438
> > >>>   [junit] There were 3 failures:
> > >>>   [junit] 1)
testCapabilities(org.postgresql.test.jdbc2.DatabaseMetaDataTest)junit.framework.AssertionFailedError
> > >>>   [junit]     at org.postgresql.test.jdbc2.DatabaseMetaDataTest.testCapabilities(DatabaseMetaDataTest.java:104)
> > >>>
> > >>>
> > >this needs to be fixed in the test case
> > >
> > >
> > >>>   [junit] 2)
testForeignKeys(org.postgresql.test.jdbc2.DatabaseMetaDataTest)junit.framework.AssertionFailedError
> > >>>   [junit]     at org.postgresql.test.jdbc2.DatabaseMetaDataTest.testForeignKeys(DatabaseMetaDataTest.java:265)
> > >>>
> > >>>
> > >this needs to be fixed in the test case, and is a result of a late
> > >change
> > >
> > >
> > >>>   [junit] 3) testSetTimestamp(org.postgresql.test.jdbc2.TimestampTest)junit.framework.AssertionFailedError
> > >>>   [junit]     at org.postgresql.test.jdbc2.TimestampTest.timestampTest(TimestampTest.java:120)
> > >>>   [junit]     at org.postgresql.test.jdbc2.TimestampTest.testSetTimestamp(TimestampTest.java:92)
> > >>>
> > >>>
> > >this one I don't know anything about, but have seen it
> > >
> > >
> > >>>   [junit] FAILURES!!!
> > >>>   [junit] Tests run: 56,  Failures: 3,  Errors: 0
> > >>>
> > >>>
> > >>>
> > >>>Thanks,
> > >>>
> > >>>Mike
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>
> > >>
> > >>
> > >
> > >
> > >
> > >
> > >
> >
> >
>
> Mike
>
>
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
>
>
>