Re: [PATCHES] Re: Locale bug

> Can someone comment on this?

The ctype functions operate for unsigned characters.  I think it's a
K&R C hangover that they take int arguments, as anything smaller than
int was widened as it was passed in a function call.

There are plenty of platforms where 'char' is a signed type, including
HP-UX on PA-RISC and some NetBSD but not all NetBSD ports.

> >   othercase(ch)
> >   int            ch;
> >   {
> >   ...
> >           return toupper(ch);

That's definitely not OK.  toupper((unsigned char) ch) is.  I'm not
familiar enough with the code that is being patched to comment on the
patch that was offered, sorry.

Regards,

Giles