Re: pgsql: Fix behavior of ~> (cube, int) operator

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: Fix behavior of ~> (cube, int) operator
Дата
Msg-id 10131.1516566042@sss.pgh.pa.us
обсуждение исходный текст
Ответ на pgsql: Fix behavior of ~> (cube, int) operator  (Teodor Sigaev <teodor@sigaev.ru>)
Ответы Re: pgsql: Fix behavior of ~> (cube, int) operator  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Список pgsql-committers
Teodor Sigaev <teodor@sigaev.ru> writes:
> Fix behavior of ~> (cube, int) operator

This patch has caused Coverity to complain, correctly AFAICS, about
dead code in cube_coord_llur in the back branches:

1628         /* Inverse value if needed */
1629         if (inverse)
>>>     CID 1463943:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "result = -result;".
1630             result = -result;
1631     
1632         PG_RETURN_FLOAT8(result);

Seems to be due to sloppy division of changes between f50c80dbb (which
was not back-patched) and 563a053bd.  Please fix.

            regards, tom lane


В списке pgsql-committers по дате отправления:

Предыдущее
От: Magnus Hagander
Дата:
Сообщение: pgsql: Support huge pages on Windows
Следующее
От: Magnus Hagander
Дата:
Сообщение: pgsql: Fix docs typo