"Dave Page" <dpage@vale-housing.co.uk> writes:
> The patch below removes attempts to drop objects before creating them
> from the int_aggregate and pgstattuple SQL scripts. This causes the
> script to fail on databases where the affected objects don't already
> exist when the script is executed by the Win32 installer, pgAdmin or any
> other interface that executes scripts 'as-is'. None of the other contrib
> scripts appear do this.
Seems reasonable. You could also make the argument that the DROPs
actually risk dropping the wrong object, since they could find a
matching name in the schema search path that is not in the current
schema (and thus not really a conflict).
regards, tom lane