On Sat, 2020-12-05 at 13:03 -0500, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>
> > The attached patch changes definitions like
> > #define FOO 0x01
> > #define BAR 0x02
> > to
> > #define FOO (1 << 0)
> > #define BAR (1 << 1)
> > etc.
>
> > Both styles are currently in use, but the latter style seems more
> > readable and easier to update.
>
> FWIW, personally I'd vote for doing the exact opposite. When you are
> debugging and examining the contents of a bitmask variable, it's easier to
> correlate a value like "0x03" with definitions made in the former style.
> Or at least I think so; maybe others see it differently.
+1
Laurenz Albe