Re: Simplify create_merge_append_path a bit for clarity

Поиск
Список
Период
Сортировка
От Alena Rybakina
Тема Re: Simplify create_merge_append_path a bit for clarity
Дата
Msg-id 0cf04512-016f-4fcc-b3f9-cefda0390a19@yandex.ru
обсуждение исходный текст
Ответ на Simplify create_merge_append_path a bit for clarity  (Richard Guo <guofenglinux@gmail.com>)
Ответы Re: Simplify create_merge_append_path a bit for clarity  (Richard Guo <guofenglinux@gmail.com>)
Список pgsql-hackers
Hi!

On 11.08.2023 05:31, Richard Guo wrote:
> As explained in the comments for generate_orderedappend_paths, we don't
> currently support parameterized MergeAppend paths, and it doesn't seem
> like going to change anytime soon.  Based on that,  we could simplify
> create_merge_append_path a bit, such as set param_info to NULL directly
> rather than call get_appendrel_parampathinfo() for it.  We already have
> an Assert on that in create_merge_append_plan.
>
> I understand that the change would not make any difference for
> performance, it's just for clarity's sake.

I agree with you, and we can indeed directly set the param_info value to 
NULL, and there are enough comments here to explain.

I didn't find anything else to add in your patch.

-- 
Regards,
Alena Rybakina




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Laurenz Albe
Дата:
Сообщение: Bug: RLS policy FOR SELECT is used to check new rows
Следующее
От: "Drouvot, Bertrand"
Дата:
Сообщение: Re: Synchronizing slots from primary to standby