Re: Fix pg_stat_reset_single_table_counters function

Поиск
Список
Период
Сортировка
От Kyotaro Horiguchi
Тема Re: Fix pg_stat_reset_single_table_counters function
Дата
Msg-id 0c0dfe89-528c-c93f-bd00-e21781336ff0@gmail.com
обсуждение исходный текст
Ответ на Re: Fix pg_stat_reset_single_table_counters function  (Masahiro Ikeda <ikedamsh@oss.nttdata.com>)
Ответы Re: Fix pg_stat_reset_single_table_counters function  (Masahiro Ikeda <ikedamsh@oss.nttdata.com>)
Re: Fix pg_stat_reset_single_table_counters function  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Apologies. In the previous mail, I mistakenly addressed it to the wrong 
recipients. Reposted.

On 2023/08/15 14:13, Masahiro Ikeda wrote:
> On 2023-08-15 11:48, Masahiko Sawada wrote:
>> +COMMENT ON DATABASE :current_database IS 'This is a test comment';
>> -- insert or update in 'pg_shdescription'
>>
>> I think the current_database should be quoted (see other examples
>> where using current_database(), e.g. collate.linux.utf8.sql). Also it
>> would be better to reset the comment after the test.
>
> Thanks! I fixed the issues in the v4 patch.

I'm not sure about others, but I would avoid using the name 
"current_database" for the variable.

I would just use "database" or "db" instead.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Masahiro Ikeda
Дата:
Сообщение: Re: Rethink the wait event names for postgres_fdw, dblink and etc
Следующее
От: Chapman Flack
Дата:
Сообщение: Re: Extract numeric filed in JSONB more effectively