Re: Enable data checksums by default

Поиск
Список
Период
Сортировка
От Tomas Vondra
Тема Re: Enable data checksums by default
Дата
Msg-id 0adc8212-52dd-405d-bb47-9b5d6a0d2e80@vondra.me
обсуждение исходный текст
Ответ на Re: Enable data checksums by default  (Peter Eisentraut <peter@eisentraut.org>)
Ответы Re: Enable data checksums by default
Re: Enable data checksums by default
Список pgsql-hackers
On 10/16/24 08:54, Peter Eisentraut wrote:
> On 14.10.24 11:28, Peter Eisentraut wrote:
>> On 03.10.24 23:13, Nathan Bossart wrote:
>>> On Tue, Oct 01, 2024 at 11:15:02AM -0400, Peter Eisentraut wrote:
>>>> I have committed 0001 (the new option) and 0004 (the docs tweak).  I
>>>> think
>>>> there is consensus for the rest, too, but I'll leave it for a few
>>>> more days
>>>> to think about.  I guess the test failure has to be addressed.
>>>
>>> Here is a rebased patch with the test fix (for cfbot).  I have made no
>>> other changes.
>>
>> I have committed the test changes (patch 0002).  (I renamed the option
>> to no_data_checksums to keep the wording consistent with the initdb
>> option.)
>>
>> Right now, with checksums off by default, this doesn't do much, but
>> you can test this like
>>
>>      PG_TEST_INITDB_EXTRA_OPTS=--data-checksums meson test ...
>>
>> and everything will pass.  To make that work, I had to adjust the
>> order of how the initdb options are assembled in Cluster.pm a bit.
>>
>> I will work on the patch that flips the default next.
> 
> The patch that flips the default has been committed.
> 
> I also started a PG18 open items page and made a note that we follow up
> on the upgrade experience, as was discussed in this thread.
> 
> https://wiki.postgresql.org/wiki/PostgreSQL_18_Open_Items
> 

Regarding the open item, can someone explain what exactly are we
planning to evaluate mid-beta?

We went through the open items on the RMT team meeting today, and my
impression was the questions are mostly about performance of having
checksums by default, but now I realize the thread talks about "upgrade
experience" which seems fairly wide.

So, what kind of data we expect to gather in order to evaluate this?
Who's expected to collect it and evaluate this?

regards

-- 
Tomas Vondra




В списке pgsql-hackers по дате отправления: