[PATCH] Win32 native fixes after SSL updates (+more)
От | Magnus Naeslund(f) |
---|---|
Тема | [PATCH] Win32 native fixes after SSL updates (+more) |
Дата | |
Msg-id | 0ace01c22e3f$580f24c0$f80c0a0a@mnd обсуждение исходный текст |
Ответы |
Re: [PATCH] Win32 native fixes after SSL updates (+more)
Re: [PATCH] Win32 native fixes after SSL updates (+more) |
Список | pgsql-hackers |
Hello, i noticed that win32 native stopped working/compiling after the SSL merge. So i took the opportunity to fix some stuff: 1. Made the thing compile (typos & needed definitions) with the new pqsecure_* stuff, and added fe-secure.c to the win32.makmakefile. 2. Fixed some MULTIBYTE compile errors (when building without MB support). 3. Made it do that you can build with debug info: "nmake -f win32.mak DEBUG=1". 4. Misc small compiler speedup changes. The resulting .dll has been tested in production, and everything seems ok. I CC:ed -hackers because i'm not sure about two things: 1. In libpq-int.h I typedef ssize_t as an int because Visual C (v6.0) doesn't define ssize_t. Is that ok, or is there anystandard about what type should be used for ssize_t? 2. To keep the .dll api consistent regarding MULTIBYTE I just return -1 in fe-connect.c:PQsetClientEncoding() instead oftaking away the whole function. I wonder if i should do any compares with the conn->client_encoding and return 0 if nothingwould have changed (if so how do i check that?). Regards Magnus Naeslund -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Programmer/Networker [|] Magnus Naeslund -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
В списке pgsql-hackers по дате отправления: