Re: pgsql: Introduce pg_shmem_allocations_numa view
| От | Heikki Linnakangas |
|---|---|
| Тема | Re: pgsql: Introduce pg_shmem_allocations_numa view |
| Дата | |
| Msg-id | 0aac5d44-0063-458d-8792-e9bbbc37fe72@iki.fi обсуждение исходный текст |
| Ответ на | Re: pgsql: Introduce pg_shmem_allocations_numa view (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>) |
| Список | pgsql-hackers |
On 12/02/2026 19:23, Bertrand Drouvot wrote: > Hi, > > On Thu, Feb 12, 2026 at 05:43:47PM +0100, Álvaro Herrera wrote: >> On 2026-Feb-12, Heikki Linnakangas wrote: >> >>> I just noticed that this (commit bf1119d74a: Add CHECK_FOR_INTERRUPTS into >>> pg_numa_query_pages) made the function unusable in frontend programs, >>> because CHECK_FOR_INTERRUPTS is server only. > > Good catch! Out of curiosity how did you find the issue? Were you building a > client tool making used of pg_numa_query_pages()? I was working on my "interrupts vs signals" patch, which needed to change some #includes in pg_numa.c, when I spotted that it already had that issue. >> It's not used in frontend >>> programs today, but it was placed in src/port/ with the idea that it could >>> be. >> >> Your patch LGTM. > > +1 Pushed, thanks! - Heikki
В списке pgsql-hackers по дате отправления: