Re: Remaining dependency on setlocale()

> On Dec 13, 2025, at 04:11, Jeff Davis <pgsql@j-davis.com> wrote:
>
> I believe v12 0001-0005 are about ready for commit, and 0003 should be
> backported.

I quickly went through 0001-0005, and got a few nitpicks:

1 - 0001
```
+    int            match_mblen pg_attribute_unused();
```

Why this variable is marked unused? It’s actually used.

2 - 0002

I did a search and found one place that you missed at line 181 in pg_locale.h
```
extern bool char_is_cased(char ch, pg_locale_t locale);
```

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/