> On 10 Nov 2025, at 12:29, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> There was a suggestion earlier to make SLRU_PAGES_PER_SEGMENT a configure option [2]. I don't want to go that far;
pg_config_manual.hseems like the right level of configurability to me.
Agreed. The thread referenced above never really answered why a configure time
option would be needed.
+ uint32 slru_pages_per_segment; /* size of each SLRU segment */
Should this be expanded ever so slightly? A new reader of the code might
wonder about the relationship between "pages_per" and "size".
No objections (apart from the catversion =)) from reading the patch.
--
Daniel Gustafsson