Re: Crash on promotion when recovery.conf is renamed
От | Tsunakawa, Takayuki |
---|---|
Тема | Re: Crash on promotion when recovery.conf is renamed |
Дата | |
Msg-id | 0A3221C70F24FB45833433255569204D1F6BBBF0@G01JPEXMBYT05 обсуждение исходный текст |
Ответ на | Re: [HACKERS] Crash on promotion when recovery.conf is renamed (Michael Paquier <michael.paquier@gmail.com>) |
Ответы |
Re: Crash on promotion when recovery.conf is renamed
Re: Crash on promotion when recovery.conf is renamed |
Список | pgsql-hackers |
From: pgsql-hackers-owner@postgresql.org > [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Michael Paquier > Moved to CF 2017-03. Both patches still apply. Sorry to be late for reviewing this, but done now. The patch applied, make check passed, and the code looks almost good. I could successfully perform a simple archive recovery. Finally, I broke the 2pc state file while the server is down,and could confirm that the server failed to start as expected, emitting a FATAL message. Worked nicely. Just two cosmetic points: (1) Other places use "two-phase state file", not "two-phase file". (2) All other places in twophase.c and most places in other files put ereport() and errmsg() on separate lines. I think it wouldbe better to align with surrounding code. + ereport(FATAL, (errmsg("corrupted two-phase file \"%s\"", Regards Takayuki Tsunakawa
В списке pgsql-hackers по дате отправления: