> On 5 Mar 2020, at 19:36, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
> On 2020-Mar-05, Tom Lane wrote:
>
>> As long as we're thinking of zapping code that is long past its sell-by
>> date, I propose getting rid of this stanza in indexcmds.c, which
>> basically causes CREATE INDEX to ignore certain opclass specifications:
>
> I agree, this should be fine to remove.
The attached patchset removes this stanza as well.
When poking around here I realized that defGetStringList was also left unused.
It was added with the logical decoding code but the single callsite has since
been removed. As it's published in a header we might not want to remove it,
but I figured I'd bring it up as were talking about removing code.
cheers ./daniel