Re: Avoid extra Sort nodes between WindowAggs when sorting can bereused

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: Avoid extra Sort nodes between WindowAggs when sorting can bereused
Дата
Msg-id 09AAAA20-F9AB-4F15-98A8-04B146BED6FE@yesql.se
обсуждение исходный текст
Ответ на Re: Avoid extra Sort nodes between WindowAggs when sorting can be reused  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Список pgsql-hackers
> On 12 Sep 2018, at 22:15, Andrew Gierth <andrew@tao11.riddles.org.uk> wrote:

> WindowClauseSortNode - I don't like this name, because it's not actually
> a Node of any kind. How about WindowSortData?

That’s a good point.  I probably would’ve named it WindowClauseSortData since
it acts on WindowClauses, but that might just be overly verbose.

> Any comments? (no need to post further patches unless there's some major
> change needed)

I have no objections to the comments made in this review, only the above
nitpick.

Thanks for picking this up!

cheers ./daniel

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrew Gierth
Дата:
Сообщение: Re: Avoid extra Sort nodes between WindowAggs when sorting can be reused
Следующее
От: Andres Freund
Дата:
Сообщение: Re: [patch] Support LLVM 7