Re: pgsql: Add missing string terminator
| От | Peter Eisentraut |
|---|---|
| Тема | Re: pgsql: Add missing string terminator |
| Дата | |
| Msg-id | 0755ae22-4e04-4c69-b344-8c4db54d6e23@eisentraut.org обсуждение исходный текст |
| Ответ на | Re: pgsql: Add missing string terminator (David Rowley <dgrowleyml@gmail.com>) |
| Ответы |
Re: pgsql: Add missing string terminator
|
| Список | pgsql-committers |
On 30.04.25 13:56, David Rowley wrote: > On Wed, 30 Apr 2025 at 23:43, David Rowley <dgrowleyml@gmail.com> wrote: >> memcpy() would make more sense IMO, since the length is >> known already. I'm fine with either, however. > > In case you're looking for inspiration on a standard to follow, > commits such as 586dd5d6a did seem to favour memcpy() when the length > was known and only use strlcpy() when it wasn't. It looks like the memcpy() uses in that commit are for cases where we don't want/need the null terminator. I think it's best in general to use str* for strings and mem* for not-strings. That's easier to read and also better for static analyzers etc.
В списке pgsql-committers по дате отправления: