> On 27 May 2025, at 05:51, Michael Paquier <michael@paquier.xyz> wrote:
>
> <v3-0001-Add-InjectionPointList-to-retrieve-list-of-inject.patch>
> <v3-0002-injection_points-Add-function-to-flush-injection-.patch>
> <v3-0003-Add-regression-test-for-2PC-visibility-check-on-s.patch>
I've made another round of looking into these patches.
I think it's fine that private data is not included. But the feature looks orthogonal, and I do not see specific
reasonswhy it should be omitted when IPs are persisted.
Another idea of improvement is using distinguishable errors in injection_shmem_startup(). Like differentiating between
readerror and wrong magic number.
But there's no big value in these improvements, so the patch is fine as is too.
Best regards, Andrey Borodin.