Re: More #ifdef fun: src/interfaces/libpq/win32.c
От | Hiroshi Saito |
---|---|
Тема | Re: More #ifdef fun: src/interfaces/libpq/win32.c |
Дата | |
Msg-id | 02e601c6a86c$d7b649a0$0801a8c0@IBMC4B5932F74B обсуждение исходный текст |
Ответ на | More #ifdef fun: src/interfaces/libpq/win32.c (Tom Lane <tgl@sss.pgh.pa.us>) |
Список | pgsql-hackers |
Hi Tom-san. I think that it should be in this way. #include "postgres_fe.h" #ifdef WIN32 #include "win32.h" #endif However, I am still under try by the reason for seeing the error of now a few. Regards, Hiroshi Saito ----- Original Message ----- From: "Tom Lane" > src/interfaces/libpq/win32.c contains > > /* Declared here to avoid pulling in all includes, which causes name collissions */ > #ifdef ENABLE_NLS > extern char * > libpq_gettext(const char *msgid) > __attribute__((format_arg(1))); > #else > #define libpq_gettext(x) (x) > #endif > > Now, since it has nowhere bothered to #include pg_config.h, ENABLE_NLS > will certainly not be defined, and so this code always fails to invoke > gettext. > > This may not be real important since the file appears to use gettext > only here: > > if (!success) > sprintf(strerrbuf, libpq_gettext("Unknown socket error (0x%08X/%i)"), err, err); > > but it's still pretty bogus. > > Without a Windows machine, I'm not in a position to try making this file > properly include postgres_fe.h, or at least c.h, but someone ought to > try harder. > > regards, tom lane
В списке pgsql-hackers по дате отправления: