> On Jun 2, 2021, at 1:43 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
>
> <short-version-comments.patch>
It's not the fault of your patch, but the docs seem to be misleading in ways that your comments don't fix. (Or perhaps
myWindows knowledge is just too lacking to realize why these instructions are ok?)
Prior to where your patch makes changes, the docs say, "If you are building PostgreSQL for Microsoft Windows, read this
chapterif you intend to build with MinGW or Cygwin". I think going on to tell the users to use `su` is a bit odd.
Doesthat exist in standard MinGW and Cygwin environments? I thought "run as" was the Windows option for this.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company