Re: Review : Add hooks for pre- and post-processor executables for COPY and \copy

<div class="WordSection1"><p class="MsoNormal"><span lang="EN-US"
style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D">HiAmit,</span><p class="MsoNormal"><span
lang="EN-US"style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D"> </span><p class="MsoNormal"><span
lang="EN-US"style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D">Thank you for your review.  I’ve
rebasedand updated the patch.  </span><span lang="EN-US"
style="font-size:10.0pt;font-family:"Arial","sans-serif"">Pleasefind attached the patch.</span><span lang="EN-US"
style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D"></span><pclass="MsoNormal"><span lang="EN-US"
style="font-size:10.0pt;font-family:"Arial","sans-serif""><br/><tt><b><span
style="font-family:"Arial","sans-serif"">>Code Review comments:</span></b></tt><br /><tt><span
style="font-family:"Arial","sans-serif"">>---------------------</span></tt><br />>     <br /><tt><span
style="font-family:"Arial","sans-serif"">>1. Modify the comment in function header of: parse_slash_copy</span></tt>
(needsto modify for new syntax)<br /><br /><tt><span style="font-family:"Arial","sans-serif""></span></tt></span><p
class="MsoNormal"><tt><spanlang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif"">Done.</span></tt><p
class="MsoNormal"><tt><spanlang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif""> </span></tt><p
class="MsoNormal"><tt><spanlang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif"">> 2. Comments for
functionsOpenPipeStream & ClosePipeStream are missing. <b>        </b></span></tt><p class="MsoNormal"><tt><span
lang="EN-US"style="font-size:10.0pt;font-family:"Arial","sans-serif""> </span></tt><p class="MsoNormal"><tt><span
lang="EN-US"style="font-size:10.0pt;font-family:"Arial","sans-serif"">Done.</span></tt><p class="MsoNormal"><tt><span
lang="EN-US"style="font-size:10.0pt;font-family:"Arial","sans-serif""> </span></tt><p class="MsoNormal"><tt><span
lang="EN-US"style="font-size:10.0pt;font-family:"Arial","sans-serif"">> 3. Any Script errors are not directly
visibleto user; If there problems in script no way to cleanup.</span></tt><span lang="EN-US"
style="font-size:10.0pt;font-family:"Arial","sans-serif""><tt><span
style="font-family:"Arial","sans-serif"">  </span></tt></span><pclass="MsoNormal"><tt><span lang="EN-US"
style="font-size:10.0pt;font-family:"Arial","sans-serif"">>   Shouldn’t this be mentioned in User
Manual.</span></tt><spanlang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D"></span><p
class="MsoNormal"><spanlang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif""> </span><p
class="MsoNormal"><spanlang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif"">Done.  Please see the
documentationnote on the \copy instruction in psql-ref.sgml.</span><p class="MsoNormal"><span lang="EN-US"
style="font-size:10.0pt;font-family:"Arial","sans-serif""><br/><tt><b><span
style="font-family:"Arial","sans-serif"">>Test case issues:</span></b></tt><br /><tt><span
style="font-family:"Arial","sans-serif"">>------------------</span></tt><br /><tt><span
style="font-family:"Arial","sans-serif"">>1. "Broken pipe" is not handled in case of psql "\copy"
command;</span></tt><br/><tt><span style="font-family:"Arial","sans-serif"">>     Issue are as
follows:</span></tt><br/><tt><span style="font-family:"Arial","sans-serif"">>         Following are verified on
SuSE-Linux10.2.</span></tt><br /><tt><span style="font-family:"Arial","sans-serif"">>         1) psql is exiting
when"\COPY xxx TO" command is issued and command/script is not found</span></tt> </span><span lang="EN-US"></span><p
class="MsoNormal"style="margin-bottom:12.0pt"><tt><span lang="EN-US"
style="font-size:10.0pt;font-family:"Arial","sans-serif"">>                When popen is called in write mode it is
creatingvalid file descriptor and when it tries to write to file "Broken pipe" error is > coming which is not
handled.</span></tt><span lang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif""><br /><tt><span
style="font-family:"Arial","sans-serif"">>                        psql# \copy pgbench_accounts TO PROGRAM
'../compress.shpgbench_accounts4.txt'</span></tt><br /><tt><span style="font-family:"Arial","sans-serif"">>        
2)When "\copy" command is in progress then program/command is killed/"crashed due to any problem" </span></tt><br
/><tt><spanstyle="font-family:"Arial","sans-serif"">>            psql is exiting.</span></tt></span><p
class="MsoNormal"><spanlang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif"">This is a headache.  I
haveno idea how to solve this.</span><p class="MsoNormal"><span lang="EN-US"
style="font-size:10.0pt;font-family:"Arial","sans-serif""> </span><pclass="MsoNormal"><span lang="EN-US"
style="font-size:10.0pt;font-family:"Arial","sans-serif"">Sorryfor the long delay in responding.</span><p
class="MsoNormal"><spanlang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif""> </span><p
class="MsoNormal"><spanlang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif"">Best regards,</span><p
class="MsoNormal"><spanlang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif"">Etsuro
Fujita</span></div>