Re: win32mak_patch

Hi Magnus.

----- Original Message -----
From: "Magnus Hagander" <magnus@hagander.net>


>> Um, win32.mak of libpq needed to add dirmod.c --
>> libpq.lib(fe-connect.obj) : error LNK2001: (snip-sjis message)
>> "_pgwin32_safestat"
>>
>> Then, Is containing in libpq wrong? I'm confused for a while...
>
> Yes, you are missing something :-)

Ahh Sure, I had missed discussion of this improvement.
Then, It seems that win32.mak has been forgotten.

>
> The patch for win32.mak I'm happy to apply, it looks fine.

Yeah, Anyway I think that the equipment is required.

>
> The patch for exports.txt does not look fine.

About it, I do not have firm belief yet. However, It does not put in there.

>
> Can you confirm that you can build things properly *with* the patch to
> win32.mak but *without* the patch to exports.txt?

http://winpg.jp/~saito/pg_work/WIN32_BUILD_INF/psql_win32_n.mak
I checked the build without correction of exports.txt.

>
> Also, I assume this needs to be backpatched?

Yes, Since you have already done, I think that it is required.
Thanks!

Regards,
Hiroshi Saito