Re: 7.3 and HEAD broken for dropped columns of dropped types

Поиск
Список
Период
Сортировка
От Christopher Kings-Lynne
Тема Re: 7.3 and HEAD broken for dropped columns of dropped types
Дата
Msg-id 009501c3182a$177013e0$6500a8c0@fhp.internal
обсуждение исходный текст
Ответ на 7.3 and HEAD broken for dropped columns of dropped types  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
> I am thinking that it might be a good idea for ALTER TABLE DROP COLUMN
> to reset atttypid to zero in the dropped column's pg_attribute row.
> This would help catch any other places that are depending on a dropped
> column's atttypid to still be valid.  On the other hand, it would
> possibly confuse applications that are looking at pg_attribute.
> Comments anyone?

I think you should zero it - we keep finding these little places where we've
missed thinking about dropped columns and that should flush them out.  Any
application looking at the type of a dropped column is confused anyway...
(Or they're doing a join...which could result in the dropped column not
appearing in their result set but hey...)

Chris



В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Andrew Dunstan"
Дата:
Сообщение: Re: Plans for index names unique to a table?
Следующее
От: alex avriette
Дата:
Сообщение: patch src/bin/psql/help.c