Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench

Поиск
Список
Период
Сортировка
Искать
От
Fabien COELHO
Тема
Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench
Дата
Msg-id
alpine.DEB.2.22.394.2106261713440.482873@pseudo
Ответ на
Список
Дерево обсуждения
pgsql: Fix pattern matching logic for logs in TAP tests of pgbench Michael Paquier <michael@paquier.xyz>
Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench Michael Paquier <michael@paquier.xyz>
Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench Michael Paquier <michael@paquier.xyz>
Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench Andrew Dunstan <andrew@dunslane.net>
Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench Michael Paquier <michael@paquier.xyz>
Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench Andrew Dunstan <andrew@dunslane.net>
Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench Andrew Dunstan <andrew@dunslane.net>
Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench Michael Paquier <michael@paquier.xyz>
Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench Andrew Dunstan <andrew@dunslane.net>
Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench Michael Paquier <michael@paquier.xyz>
Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench Andrew Dunstan <andrew@dunslane.net>
Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench Fabien COELHO <coelho@cri.ensmp.fr>

>> However, if slurp_file fails it raises an exception and aborts the
>> whole TAP unexpectedly, which is pretty unclean. So I'd suggest to
>> keep the eval, as attached. I tested it by changing the file name so
>> that the slurp fails.
>
> Seem quite unnecessary. We haven't found that to be an issue elsewhere
> in the code where slurp_file is used. And in the present case we know
> the file exists because we got its name from list_files().

Fine with me!

-- 
Fabien.


В списке pgsql-committers по дате отправления
От: Andrew Dunstan
Дата:
От: Tom Lane
Дата:
FAQ