Re: Redundant/mis-use of _(x) gettext macro?

Поиск
Список
Период
Сортировка
Искать
От
Álvaro Herrera
Тема
Re: Redundant/mis-use of _(x) gettext macro?
Дата
в 19:44:45
Msg-id
airjxKXx7aTG8kfE@alvherre.pgsql
Ответ на
Список
Дерево обсуждения
Redundant/mis-use of _(x) gettext macro? Peter Smith <smithpb2250@gmail.com>
Re: Redundant/mis-use of _(x) gettext macro? Álvaro Herrera <alvherre@kurilemu.de>
Re: Redundant/mis-use of _(x) gettext macro? Peter Smith <smithpb2250@gmail.com>
Re: Redundant/mis-use of _(x) gettext macro? Chao Li <li.evan.chao@gmail.com>
Re: Redundant/mis-use of _(x) gettext macro? Tom Lane <tgl@sss.pgh.pa.us>
Re: Redundant/mis-use of _(x) gettext macro? Peter Smith <smithpb2250@gmail.com>
Re: Redundant/mis-use of _(x) gettext macro? Peter Smith <smithpb2250@gmail.com>
Re: Redundant/mis-use of _(x) gettext macro? Álvaro Herrera <alvherre@kurilemu.de>
Re: Redundant/mis-use of _(x) gettext macro? Peter Smith <smithpb2250@gmail.com>
Re: Redundant/mis-use of _(x) gettext macro? Álvaro Herrera <alvherre@kurilemu.de>
Re: Redundant/mis-use of _(x) gettext macro? David Rowley <dgrowleyml@gmail.com>
Re: Redundant/mis-use of _(x) gettext macro? Peter Smith <smithpb2250@gmail.com>
Re: Redundant/mis-use of _(x) gettext macro? Álvaro Herrera <alvherre@kurilemu.de>
Re: Redundant/mis-use of _(x) gettext macro? Álvaro Herrera <alvherre@kurilemu.de>
Re: Redundant/mis-use of _(x) gettext macro? Peter Smith <smithpb2250@gmail.com>
Re: Redundant/mis-use of _(x) gettext macro? Álvaro Herrera <alvherre@kurilemu.de>
Re: Redundant/mis-use of _(x) gettext macro? Chao Li <li.evan.chao@gmail.com>
On 2026-Apr-24, Peter Smith wrote:

> OK. Including the comma within a larger translated string seems like a
> better idea.
[...]
> Also, why did you choose to implement `last` versus `first` logic?
> e.g. How about this?

In the end I decided to go with the flow and changed to use "first"
logic rather than "last".  I also figured that we should change the
other two places you pointed out at the start of the thread to use the
same coding style.  Since this is mostly cosmetic, I don't feel
compelled to back-patch it, and pushed only to master.

Another place I noticed while looking this over is psql's
describeOneTableDetails(), per the attached patch.  It's essentially
more of the same, but arguably different enough that I judged it
warranted posting before pushing.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
В списке pgsql-hackers по дате отправления
От: Jacob Champion
Дата:
От: Salma El-Sayed
Дата:
FAQ