Re: Fix memory leak in gist_page_items() of pageinspect
От
Michael Paquier
Тема
Re: Fix memory leak in gist_page_items() of pageinspect
Дата
Msg-id
aVy5zEAG8memlM_0@paquier.xyz
Ответ на
Список
Дерево обсуждения
Fix memory leak in gist_page_items() of pageinspect Chao Li <li.evan.chao@gmail.com>
Re: Fix memory leak in gist_page_items() of pageinspect Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Re: Fix memory leak in gist_page_items() of pageinspect Michael Paquier <michael@paquier.xyz>
Re: Fix memory leak in gist_page_items() of pageinspect Heikki Linnakangas <hlinnaka@iki.fi>
Re: Fix memory leak in gist_page_items() of pageinspect Daniel Gustafsson <daniel@yesql.se>
Re: Fix memory leak in gist_page_items() of pageinspect Chao Li <li.evan.chao@gmail.com>
Re: Fix memory leak in gist_page_items() of pageinspect Michael Paquier <michael@paquier.xyz>
Re: Fix memory leak in gist_page_items() of pageinspect Chao Li <li.evan.chao@gmail.com>
Re: Fix memory leak in gist_page_items() of pageinspect Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Re: Fix memory leak in gist_page_items() of pageinspect Michael Paquier <michael@paquier.xyz>
Re: Fix memory leak in gist_page_items() of pageinspect Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Re: Fix memory leak in gist_page_items() of pageinspect Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Re: Fix memory leak in gist_page_items() of pageinspect Chao Li <li.evan.chao@gmail.com>
Re: Fix memory leak in gist_page_items() of pageinspect Chao Li <li.evan.chao@gmail.com>
Re: Fix memory leak in gist_page_items() of pageinspect Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Re: Fix memory leak in gist_page_items() of pageinspect Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
On Mon, Dec 22, 2025 at 10:41:44AM +0800, Chao Li wrote: > On Dec 19, 2025, at 18:26, Bertrand Drouvot wrote: >> Thanks! Done that way in the attached. > > LGTM. As the immediately following statement is if (!IS_INDEX(rel)), > adding a comment to relation_open() feels very necessary. The fact that partitioned indexes are not allowed in these functions is not a fact that stands out, and one would be indeed tempted to make the switch. The tests would complain on relation open, though. Reworded the comment a bit and applied the result. -- Michael
В списке pgsql-hackers по дате отправления
