Re: GetSubscriptionRelations declares too many scan keys

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: GetSubscriptionRelations declares too many scan keys
Дата
в 07:50:46
Msg-id
YJo3VscSxCQnoy1h@paquier.xyz
Ответ на
Список
Дерево обсуждения
GetSubscriptionRelations declares too many scan keys Peter Smith <smithpb2250@gmail.com>
Re: GetSubscriptionRelations declares too many scan keys Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: GetSubscriptionRelations declares too many scan keys Julien Rouhaud <rjuju123@gmail.com>
Re: GetSubscriptionRelations declares too many scan keys Peter Smith <smithpb2250@gmail.com>
Re: GetSubscriptionRelations declares too many scan keys Julien Rouhaud <rjuju123@gmail.com>
Re: GetSubscriptionRelations declares too many scan keys Tom Lane <tgl@sss.pgh.pa.us>
Re: GetSubscriptionRelations declares too many scan keys Michael Paquier <michael@paquier.xyz>
Re: GetSubscriptionRelations declares too many scan keys Michael Paquier <michael@paquier.xyz>
Re: GetSubscriptionRelations declares too many scan keys Peter Smith <smithpb2250@gmail.com>
Re: GetSubscriptionRelations declares too many scan keys Dilip Kumar <dilipbalaut@gmail.com>
On Mon, May 10, 2021 at 10:14:08AM -0400, Tom Lane wrote:
> Yeah, there's no real consensus about that.  But in this case there's
> a strong reason to use skey[1]: it makes the patch a very safe one-liner.
> To convert to the other pattern would require touching more code.

FWIW, what Peter S has done looks fine to me, even if it is true that
CountDBSubscriptions() uses one scan key but does not use an array.

And that makes the code slightly easier to follow.
--
Michael
В списке pgsql-hackers по дате отправления
От: Julien Rouhaud
Дата:
От: Michael Paquier
Дата:
FAQ