Dear Tom,
>> (2) This boolean is tested in postinit.c:ReverifyMyDatabase,
>> and InitializeDatabase is called if necessary.
>
> And what happens if multiple backends try to connect at the same time?
I took care of that one!
There is a lock on the update of pg_database when switching off datisinit.
The backend which gets the lock is to update the schema ownership, and
others will wait for the lock to be released, and skip the stuff.
I don't think I forgot something, but I may be wrong.
Also, as I noted I used SPI internally to do that simply with sql. I don't
know if this is an issue.
>> (4) Some validation is added.
>
> I do not think it's a good idea for the regression tests to do anything
> to any databases other than regression. Especially not databases with
> names that might match people's real databases.
Oh, you mean calvin and hobbes might use postgresql? ;-)
Ok, so I guess I can use regressionuser[123], regression[123] as names in
the validation. Writing tests cases is not fun, so I tried to put some fun
by using these characters.
--
Fabien Coelho - coelho@cri.ensmp.fr