On Mon Jun 12, 2023 at 4:24 PM CDT, Peter Eisentraut wrote:
> On 12.06.23 20:48, Tristan Partin wrote:
> > Attached you will find a v3 with the offending commits removed. I did
> > leave the overrides in since you didn't mention it in your last email.
>
> Patches 1-14 look ok to me. (But I didn't test anything, so some
> caveats about whether the non-cosmetic patches actually work apply.) If
> we're fine-tuning the capitalization the options descriptions, let's
> also turn "tap tests" into "TAP tests" and "TCL" into "Tcl".
I'll get to that.
> Patch 15 about the wrap integration, I'm not sure. I share the concerns
> about whether this is worth maintaining. Maybe put this patch into the
> commitfest separately, to allow for further study and testing. (The
> other patches, if they are acceptable, ought to go into PG16, I think.)
Ok. I will split it off for further discussion. Expect a v4 tomorrow
with a few extra changes with regard to another review from a Meson
maintainer.
--
Tristan Partin
Neon (https://neon.tech)