Re: Non-text mode for pg_dumpall

Поиск
Список
Период
Сортировка
Искать
От
Andrew Dunstan
Тема
Re: Non-text mode for pg_dumpall
Дата
Msg-id
8354938e-6400-4dc1-b783-474886669250@dunslane.net
Ответ на
Список
Дерево обсуждения
Non-text mode for pg_dumpall Andrew Dunstan <andrew@dunslane.net>
Re: Non-text mode for pg_dumpall Nathan Bossart <nathandbossart@gmail.com>
Re: Non-text mode for pg_dumpall Andrew Dunstan <andrew@dunslane.net>
Re: Non-text mode for pg_dumpall Nathan Bossart <nathandbossart@gmail.com>
Re: Non-text mode for pg_dumpall Magnus Hagander <magnus@hagander.net>
Re: Non-text mode for pg_dumpall Nathan Bossart <nathandbossart@gmail.com>
Re: Non-text mode for pg_dumpall Magnus Hagander <magnus@hagander.net>
Re: Non-text mode for pg_dumpall Tom Lane <tgl@sss.pgh.pa.us>
Re: Non-text mode for pg_dumpall Andrew Dunstan <andrew@dunslane.net>
Re: Non-text mode for pg_dumpall Magnus Hagander <magnus@hagander.net>
Re: Non-text mode for pg_dumpall Nathan Bossart <nathandbossart@gmail.com>


On 2025-04-10 Th 5:45 PM, Ranier Vilela wrote:

Em qui., 10 de abr. de 2025 às 15:58, Andrew Dunstan <andrew@dunslane.net> escreveu:


On 2025-04-10 Th 2:38 PM, Ranier Vilela wrote:


Thanks. I have pushed these now with a few further small tweaks.

Sorry if it is not the right place.
Coverity has another resource leak alert.

trivial patch attached.




Thanks for checking. Pushed.

Andew, I think that the commit wasn't very correct.
Now the variable *q* is being destroyed inside the loop.

The patch was destroying the variable *q* (stringinfo),
after the loop while.
 


Yes, you're right. Must be blind. Fixed.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com
В списке pgsql-hackers по дате отправления
От: Matthias van de Meent
Дата:
От: Ranier Vilela
Дата:
FAQ