Re: [PROPOSAL] Client Log Output Filtering

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: [PROPOSAL] Client Log Output Filtering
Дата
Msg-id
32424.1457621519@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
[PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering Tom Lane <tgl@sss.pgh.pa.us>
Re: [PROPOSAL] Client Log Output Filtering Robert Haas <robertmhaas@gmail.com>
Re: [PROPOSAL] Client Log Output Filtering Petr Jelinek <petr@2ndquadrant.com>
Re: [PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering Tom Lane <tgl@sss.pgh.pa.us>
Re: [PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering Petr Jelinek <petr@2ndquadrant.com>
Re: [PROPOSAL] Client Log Output Filtering Tom Lane <tgl@sss.pgh.pa.us>
Re: [PROPOSAL] Client Log Output Filtering Petr Jelinek <petr@2ndquadrant.com>
Re: [PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering Tom Lane <tgl@sss.pgh.pa.us>
Re: [PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering Tom Lane <tgl@sss.pgh.pa.us>
Re: [PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [PROPOSAL] Client Log Output Filtering Tom Lane <tgl@sss.pgh.pa.us>
Re: [PROPOSAL] Client Log Output Filtering Andres Freund <andres@anarazel.de>
Re: [PROPOSAL] Client Log Output Filtering Tom Lane <tgl@sss.pgh.pa.us>
Re: [PROPOSAL] Client Log Output Filtering Andres Freund <andres@anarazel.de>
Re: [PROPOSAL] Client Log Output Filtering Robert Haas <robertmhaas@gmail.com>
Re: [PROPOSAL] Client Log Output Filtering Tom Lane <tgl@sss.pgh.pa.us>
Re: [PROPOSAL] Client Log Output Filtering Andres Freund <andres@anarazel.de>
Re: [PROPOSAL] Client Log Output Filtering Tom Lane <tgl@sss.pgh.pa.us>
Re: [PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering Tom Lane <tgl@sss.pgh.pa.us>
Re: [PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering Tom Lane <tgl@sss.pgh.pa.us>
Re: [PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering Robert Haas <robertmhaas@gmail.com>
Re: [PROPOSAL] Client Log Output Filtering Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [PROPOSAL] Client Log Output Filtering Andres Freund <andres@anarazel.de>
Re: [PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering David Steele <david@pgmasters.net>
Re: [PROPOSAL] Client Log Output Filtering Robert Haas <robertmhaas@gmail.com>
David Steele  writes:
> On 3/9/16 7:37 PM, Petr Jelinek wrote:
>> Looking at the code, this adds bool hide_from_client to edata which is
>> not initialized in errstart so that needs to be fixed.

> I figured this would take care of it:
> MemSet(edata, 0, sizeof(ErrorData));
> Since I want hide_from_client to default to false.  Am I missing something?

The patch is evidently modeled on errhidestmt and errhidectx, which are
making the same assumption for their fields.

I wonder whether, instead of continuing to proliferate random bool fields
in struct ErrorData, we oughta replace them all with an "int flags" field.
That's probably material for a separate patch though.
		regards, tom lane


В списке pgsql-hackers по дате отправления
От: Stephen Frost
Дата:
Сообщение: Re: Floating point timestamps
От: Alvaro Herrera
Дата:
FAQ