Re: trailing comment ghost-timing

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: trailing comment ghost-timing
Дата
Msg-id
29569.1388280059@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
trailing comment ghost-timing "Erik Rijkers" <er@xs4all.nl>
Re: trailing comment ghost-timing Andres Freund <andres@2ndquadrant.com>
Re: trailing comment ghost-timing "Erik Rijkers" <er@xs4all.nl>
Re: trailing comment ghost-timing Tom Lane <tgl@sss.pgh.pa.us>
Re: trailing comment ghost-timing Andres Freund <andres@2ndquadrant.com>
Re: trailing comment ghost-timing Tom Lane <tgl@sss.pgh.pa.us>
Re: trailing comment ghost-timing Andres Freund <andres@2ndquadrant.com>
Re: trailing comment ghost-timing Tom Lane <tgl@sss.pgh.pa.us>
Re: trailing comment ghost-timing Bruce Momjian <bruce@momjian.us>
Re: trailing comment ghost-timing Bruce Momjian <bruce@momjian.us>
Re: trailing comment ghost-timing Andreas Karlsson <andreas@proxel.se>
Re: trailing comment ghost-timing David Johnston <polobo@yahoo.com>
Re: trailing comment ghost-timing Andreas Karlsson <andreas@proxel.se>
Re: trailing comment ghost-timing Martijn van Oosterhout <kleptog@svana.org>
Re: trailing comment ghost-timing Andreas Karlsson <andreas@proxel.se>
Re: trailing comment ghost-timing Fabrízio de Royes Mello <fabriziomello@gmail.com>
Re: trailing comment ghost-timing Peter Eisentraut <peter_e@gmx.net>
Andres Freund  writes:
> On 2013-12-24 12:27:59 -0500, Tom Lane wrote:
>> What I was proposing was that we do include comments in what we send,
>> as long as those comments are embedded in the statement text, not
>> on lines before it.

> The common way I've seen what I've described above done as is something
> like:
> /* File:path/to/some/file.whatever Function:foo::something()
>  * Comment: Expensive, but that's ok!
>  */
> SELECT here_comes FROM my WHERE some_sql;

> If I unerstood what you propose correctly, we'd now drop that comment,
> where we sent it before?

Yeah.  But I just noticed that this would cause the regression test
results to change dramatically --- right now, most "-- comment" comments
get echoed to the output, and that would stop.  So maybe it's not such
a great idea after all.
		regards, tom lane


В списке pgsql-hackers по дате отправления
От: Alvaro Herrera
Дата:
От: Peter Eisentraut
Дата:
FAQ