meson vs make: missing/inconsistent ENV

Поиск
Список
Период
Сортировка
Искать
От
Justin Pryzby
Тема
meson vs make: missing/inconsistent ENV
Дата
Msg-id
20230226225239.GL1653@telsasoft.com
Список
Дерево обсуждения
meson vs make: missing/inconsistent ENV Justin Pryzby <pryzby@telsasoft.com>
Re: meson vs make: missing/inconsistent ENV Andres Freund <andres@anarazel.de>
Re: meson vs make: missing/inconsistent ENV Justin Pryzby <pryzby@telsasoft.com>
Re: meson vs make: missing/inconsistent ENV Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Re: meson vs make: missing/inconsistent ENV Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Re: meson vs make: missing/inconsistent ENV Andrew Dunstan <andrew@dunslane.net>
Re: meson vs make: missing/inconsistent ENV Andrew Dunstan <andrew@dunslane.net>
Re: meson vs make: missing/inconsistent ENV Michael Paquier <michael@paquier.xyz>
Re: meson vs make: missing/inconsistent ENV Andres Freund <andres@anarazel.de>
Re: meson vs make: missing/inconsistent ENV Michael Paquier <michael@paquier.xyz>
I noticed warnings:
Use of uninitialized value $ENV{"with_icu"} in string eq at /home/pryzbyj/src/postgres/src/bin/pg_dump/t/002_pg_dump.pl line 56.

and looked through: git grep ^export '*/Makefile'

and found that:
src/bin/pg_dump/meson.build is missing with_icu since 396d348b0

Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but
it's not in ./Makefile ??  Maybe that was for consistency with other
places, or pre-emptive in case the tap tests want to do tests involving
the ZSTD tool.  But it'd be better if ./Makefile had it too.

The rest I think are not errors:

src/test/meson.build is missing PG_TEST_EXTRA
src/bin/pg_upgrade/meson.build and ../src/test/recovery/meson.build
are missing REGRESS_SHLIB

Is there any consideration of promoting these or other warnings to
fatal?

-- 
Justin


В списке pgsql-hackers по дате отправления
От: Melanie Plageman
Дата:
От: Takamichi Osumi (Fujitsu)
Дата:
FAQ