Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16

Поиск
Список
Период
Сортировка
Искать
От
Nathan Bossart
Тема
Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16
Дата
Msg-id
20230120200155.GA4922@nathanxps13
Ответ на
Список
Дерево обсуждения
Change xl_hash_vacuum_one_page.ntuples from int to uint16 "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 Nathan Bossart <nathandbossart@gmail.com>
Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 Nathan Bossart <nathandbossart@gmail.com>
Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 Amit Kapila <amit.kapila16@gmail.com>
Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 Amit Kapila <amit.kapila16@gmail.com>
Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 Amit Kapila <amit.kapila16@gmail.com>
Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 Andres Freund <andres@anarazel.de>
Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 Amit Kapila <amit.kapila16@gmail.com>
On Tue, Jan 10, 2023 at 11:08:33AM +0100, Drouvot, Bertrand wrote:
> While working on [1], I noticed that xl_hash_vacuum_one_page.ntuples is an int.
> 
> Unless I'm missing something, It seems to me that it would make more sense to use an uint16 (like this is done for
> gistxlogDelete.ntodelete for example).

I think that is correct.  This value is determined by looping through
offsets, which are uint16 as well.  Should we also change the related
variables (e.g., ndeletable in _hash_vacuum_one_page()) to uint16?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com


В списке pgsql-hackers по дате отправления
От: Nathan Bossart
Дата:
От: Karl O. Pinc
Дата:
FAQ