Re: Comment and function argument names are mismatched in bugmgr.c.

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: Comment and function argument names are mismatched in bugmgr.c.
Дата
Msg-id 20160701213403.l2cl4xsqwarfj2nm@alap3.anarazel.de
обсуждение исходный текст
Ответ на Comment and function argument names are mismatched in bugmgr.c.  (Masahiko Sawada <sawada.mshk@gmail.com>)
Ответы Re: Comment and function argument names are mismatched in bugmgr.c.  (Masahiko Sawada <sawada.mshk@gmail.com>)
Список pgsql-hackers
Дерево обсуждения 
Hi,

On 2016-06-23 16:24:12 +0900, Masahiko Sawada wrote:
> By commit 428b1d6b, function WritebackContextInit is added but the
> comment of this function seems to be incorrect.
> *max_coalesce variable doesn't exist at anywhere.
> Also, I think it should be fixed that the argument name of this
> function does not match function declare in buf_internal.h.
> Patch for that attached.

Fix looks good to me, and your 'bugmgr.c' typo in $subject made me laugh
;). Pushed.

Thanks Robert, for pointing me to the thread, I had indeed missed it.

Greetings,

Andres Freund

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [sqlsmith] ERROR: plan should not reference subplan's variable
Следующее
От: Andres Freund
Дата:
Сообщение: Re: pg_replication_origin_xact_reset() and its argument variables