Re: Is analyze_new_cluster.sh still useful?

On Wed, Jun 18, 2014 at 05:41:06PM +0200, Christoph Berg wrote:
> Hi,
> 
> now that we have vacuumdb --all --analyze-in-stages in 9.4, wouldn't
> it make sense to get rid of the analyze_new_cluster.sh file which
> pg_upgrade writes? The net content is a single line which could as
> well be printed by pg_upgrade itself. Instead of an lengthy
> explanation how to invoke that manually, there should be a short note
> and a pointer to some manual section. I think the chances of people
> reading that would even be increased.

I was not a big fan of keeping analyze_new_cluster.sh with one command
in it, but it does maintain the same user API, so I guess that is why
people wanted it kept.

> Similary, I don't really see the usefulness of delete_old_cluster.sh
> as a file, when "rm -rf" could just be presented on the console for
> the admin to execute by cut-and-paste.

Uh, that could be hard because delete_old_cluster.sh also can also
delete the old major-version-specific subdirectories in tablespaces, so
I do think we need to keep that.

--  Bruce Momjian          http://momjian.us EnterpriseDB                             http://enterprisedb.com
 + Everyone has their own god. +