Re: [PATCH] DefaultACLs

* Stephen Frost (sfrost@snowman.net) wrote:
> * Robert Haas (robertmhaas@gmail.com) wrote:
> > On Wed, Jul 22, 2009 at 11:26 PM, Petr Jelinek wrote:
> > > The docs are not complete but that's up to Stephen, otherwise the patch
> > > should be finished. But I am not the reviewer :)
> > 
> > Well, perhaps we had better prod Stephen then, since complete docs are
> > a requirement for commit.
> 
> I didn't think the docs posted were terrible, but I am working on
> improving them.

Thanks to Joshua, there weren't really many changes I found for the
docs.  Here they are anyway:

grant.sgml:

+ Replace current privileges with the ones specified using 
+ .
+ The WITH GRANT OPTION parameter is not applicable 
+ because it is copied from default privileges.
+ Note: this can actually revoke some 
+ privileges because it clears all existing privileges object has and 
+ replaces them with the default ones for the schema in which this object
+ resides.

How about:

Replaces current privileges with the default privileges, as set using
, for
this object type in its current schema.
The WITH GRANT OPTION parameter is not applicable
because it is copied from default privileges.
Note: This can revoke privileges!  This
will clear all existing privileges first!  If no default privilege has
been set, the object will have all privileges revoked!

Otherwise, I thought the docs looked pretty good.
Thanks,
	Stephen